Allow section content to be function #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
sapegin
reviewed
May 19, 2019
src/loaders/utils/getSections.js
Outdated
| content: section.content(), | ||
| }, | ||
| ], | ||
| contentRelativePath, |
There was a problem hiding this comment.
You need to test that but looks like filepath prop isn't used anywhere in sections. It's passed here but I don't see where it's used:
sapegin
reviewed
May 21, 2019
Co-Authored-By: Artem Sapegin <artem@sapegin.ru>
eragon512
changed the title
Co-Authored-By: Artem Sapegin <artem@sapegin.ru>
|
@sapegin this PR is good to go, added your requested changes |
|
hey @sapegin , any more changes needed to this PR? |
sapegin
approved these changes
Jun 4, 2019
|
Thanks! |
|
🎉 This PR is included in version 9.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking this PR as a WIP, as I am not sure how to refactor to maintain consistency across the project
Refers: #1224
Edit: Removing WIP status, this PR is good to go