Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode sublinks in url to fix broken routes #1389

Merged

Conversation

mendrew
Copy link
Contributor

@mendrew mendrew commented Jun 22, 2019

Follow up of #1332
This appears #1384 has fixed the top level section link,
but any sub-links within that section are still unencoded and result
in "Page not found".

fix-sublinks-routing

Follow up of styleguidist#1332
This appears to have fixed the top level section link,
but any sub-links within that section are still unencoded and result
in "Page not found".
@codecov-io
Copy link

Codecov Report

Merging #1389 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
src/client/utils/getUrl.js 96.29% <100%> (+0.14%) ⬆️

@sapegin sapegin merged commit 44b640b into styleguidist:master Jun 24, 2019
@sapegin
Copy link
Member

sapegin commented Jun 24, 2019

Thanks!

@styleguidist-bot
Copy link
Collaborator

🎉 This PR is included in version 9.1.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants