Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fastest-levenshtein instead of leven #1641

Merged
merged 4 commits into from
Aug 3, 2020
Merged

Use fastest-levenshtein instead of leven #1641

merged 4 commits into from
Aug 3, 2020

Conversation

ka-weihe
Copy link
Contributor

fastest-levenshtein (link) is much faster than leven.

Benchmarks

N = length of strings
Numbers are in ops/sec
Higher is better.

Test Target N=4 N=8 N=16 N=32 N=64 N=128 N=256 N=512 N=1024
fastest-levenshtein 44423 23702 10764 4595 1049 291.5 86.64 22.24 5.473
leven 19688 6884 1606 436 117 30.34 7.604 1.929 0.478

@codecov
Copy link

codecov bot commented Jul 22, 2020 •
edited
Loading

Codecov Report

Merging #1641 into master will not change coverage.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
src/scripts/utils/sanitizeConfig.ts 100.00% <100.00%> (ø)

sapegin
sapegin requested changes Jul 23, 2020
View reviewed changes
Copy link
Member

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There won't be any noticeable difference for the user though I'm not against the change ;-) There's one suggestion though.

src/scripts/utils/sanitizeConfig.ts Outdated Show resolved Hide resolved
@ka-weihe ka-weihe requested a review from sapegin August 3, 2020 10:16
sapegin
sapegin approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐎

@sapegin sapegin merged commit 99d8806 into styleguidist:master Aug 3, 2020
@styleguidist-bot
Copy link
Collaborator

🎉 This PR is included in version 11.0.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Mar 14, 2021
Open
Open
@Bhanditz Bhanditz mentioned this pull request Nov 5, 2022
Open
@kopax kopax mentioned this pull request Nov 5, 2022
Open
@Bhanditz Bhanditz mentioned this pull request Nov 5, 2022
Open
This was referenced Dec 25, 2022
Open
Open
@kopax kopax mentioned this pull request Dec 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapegin sapegin sapegin approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ka-weihe @styleguidist-bot @sapegin @fzzle