Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Next.js configuration info to docs #1665

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

cesar
Copy link
Contributor

@cesar cesar commented Aug 15, 2020

Hi 👋🏽

First off, thanks for all the work on this project, really love it!

I thought it would be helpful to add a section that addresses how to configure react-styleguidist with Next.js specifically. With the pre-existing information in the webpack docs it's possible to configure, but I thought given how popular Next.js is it warranted a reference to make it more accessible. I'd also be down to adding an example project if need be. Feel free to disregard otherwise

Cheers!

Copy link
Member

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a minor suggestion ;-)

docs/Webpack.md Outdated Show resolved Hide resolved
Co-authored-by: Artem Sapegin <artem@sapegin.ru>
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #1665 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...sg-components/ComplexType/ComplexTypeRenderder.tsx 100.00% <0.00%> (ø)
.../client/rsg-components/Tooltip/TooltipRenderer.tsx 100.00% <0.00%> (ø)
src/client/rsg-components/Props/renderType.tsx 96.96% <0.00%> (+7.78%) ⬆️

@cesar cesar requested a review from sapegin August 25, 2020 23:15
@sapegin sapegin merged commit 7cefb48 into styleguidist:master Aug 26, 2020
@cesar cesar deleted the pr/add-nextjs-to-webpack-docs branch August 26, 2020 17:26
@styleguidist-bot
Copy link
Collaborator

🎉 This PR is included in version 11.0.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants