Support custom endpoints and configuration to the react-styleguidist server #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapegin
requested changes
Dec 30, 2016
| super(props); | ||
|
|
||
| this.state = { response: 'No Server Response' }; | ||
| this.handleInvokeEndpoint = this.handleInvokeEndpoint.bind(this, 'custom'); |
There was a problem hiding this comment.
Looks like you don’t use this second parameter (custom).
| return webpackConfig; | ||
| }, | ||
|
|
||
| configServer(app) { |
There was a problem hiding this comment.
I think it should be configureServer.
There was a problem hiding this comment.
Great! I like configureServer
| @@ -44,5 +45,16 @@ module.exports = function(config) { | |||
| makeWebpackConfig(env) { | |||
| return makeWebpackConfig(config, env || 'production'); | |||
| }, | |||
|
|
|||
| /** | |||
| * Return an info object containing the created server instance and the instanced webapck | |||
There was a problem hiding this comment.
Do we need this in the public API? What’s the use case?
There was a problem hiding this comment.
As discussed on gitter I'll remove it from the public API
|
Cool, thanks! |
Updated tests to reflect changes made on the API.
sapegin
approved these changes
Dec 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on gitter this PR enables styleguidist users to add new endpoints to the underlying express server.
A new field it's been added to
react-styleguidistconfig module:configServer.The registered function receive a pointer to the instanced
expressserver and can add to it new endpoints, configure plugins and middlewares.This addition is vital for projects requiring access to server-side/filesytem features like the integration with
jestsnapshot testing (snapguidist) @MicheleBertoli and I are working on.Let me know if you feel the result is not what we discussed or if you would like some change.