Fix: Use section title for isolation mode if component is not available (#965) #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapegin
requested changes
May 4, 2018
src/utils/getPageTitle.js
Outdated
| @@ -13,6 +13,10 @@ import { DisplayModes } from '../consts'; | |||
| */ | |||
| export default function getPageTitle(sections, baseTitle, displayMode) { | |||
| if (displayMode === DisplayModes.component || displayMode === DisplayModes.example) { | |||
| if (!sections[0].components || !sections[0].components.length) { | |||
There was a problem hiding this comment.
Something like this would be much more readable:
// import get from 'lodash/get';
const name = get(sections[0], 'components.0.name', sections[0].name);
return `${name} — ${baseTitle}`;
Codecov Report
|
sapegin
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #965 returning the section title, if no components are associated to the section that gets passed into the getPateTitle method.
The issue occurs when writing documentation in markdown with examples that don't directly relate to any component, such as typographic guidelines or colour patches.