-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to GitHub Actions CI. #50
Conversation
@kristerkari what's your take on this? You can see this on my fork https://github.com/XhmikosR/stylelint-config-recommended-scss/commit/6eee6b7c2761e75c9d01dfb2c57fd6a17a786823/checks?check_suite_id=245911495 |
I haven't used Github's CI before, so I think that I need to look into it a bit before switching to use it. If it has the same features as the other CI systems, then it's ok for me. |
It's actually better IMO so far. You can test fast, cross-platform, and without another 3rd-party service. It does lack some features like caching, but those will be fixed eventually. |
stylelint switched a couple of weeks ago, pretty happy with it You can see the final PR we merged adding them here: |
https link to npmcharts
Thanks for taking the time to do the changes! |
@kristerkari you haven't registered for Actions yet :/ |
I just did a few minutes ago |
Weird, I don't see them enabled yet... |
Either way, you should remove Travis and AppVeyor from apps/integrations/hooks when Actions is enabled. |
I'm currently removing AppVeoyr and Travis |
It seems that there is some kind of a waiting list since it's a Beta feature. I guess we'll just have to wait a bit for it to be enabled. |
No worries, you can revert this and make a new PR to merge when it's enabled. |
Let's see how long it takes, if it's quick, then I don't think that there is any need to revert the changes. |
This is just a basic setup, I haven't backported the branch limitations.
@kristerkari: first you will need to enable GH Actions: https://github.com/features/actions
EDIT: it seems there's a bug and on Windows they use Node.js 8.10.0 which doesn't have
npm ci
command. actions/setup-node#27