Add new shorthand data #2354

hudochenkov · 2017-02-12T08:56:46Z

Which issue, if any, is this issue related to?

Is there anything in the PR that needs further explanation?

Added new shorthand properties from #1780, except mask, because it's not clear what for this shorthand.

Removed prefixed shorthands. I don't think it's a good idea to keep list of all prefixed properties and shorthand.

I have concerns about shorthand-property-no-redundant-values. It uses shorthandData also. My concers is that it has a list of ignored shorthands. With new shorthands ignore list will be much bigger than list of shorthands supported in this rule. Maybe we should specify the list of allowed shorthands, rather using shorthandData and ignore.

davidtheclark · 2017-02-12T14:42:03Z

except mask, because it's not clear what for this shorthand.

Why is mask different from the others? I have never used it, but it's real! e.g. https://css-tricks.com/clipping-masking-css/

Removed prefixed shorthands. I don't think it's a good idea to keep list of all prefixed properties and shorthand.

I agree, but I don't like that we're removing functionality for that. Can we use Autoprefixer in the rule to remove the need for a manual list?

Maybe we should specify the list of allowed shorthands, rather using shorthandData and ignore.

Sounds good to me!

Want to add the changes above to this PR?

hudochenkov · 2017-02-12T14:54:39Z

Why is mask different from the others? I have never used it, but it's real! e.g. https://css-tricks.com/clipping-masking-css/

I know it's real, but I don't know every property for this shorthand. MDN and W3C don't make it clear. They say about mask-clip, mask-origin, and mask-border only, but mask accept more than this properties, as I see.

I agree, but I don't like that we're removing functionality for that. Can we use Autoprefixer in the rule to remove the need for a manual list?

I will look how declaration-block-no-redundant-longhand-properties, declaration-block-no-shorthand-property-overrides, and shorthand-property-no-redundant-values work and see what can be done.

Maybe we should specify the list of allowed shorthands, rather using shorthandData and ignore.

Sounds good to me!

Want to add the changes above to this PR?

Sure!

davidtheclark · 2017-02-12T14:56:34Z

@hudochenkov This page looks helpful: https://tympanus.net/codrops/css_reference/mask/

…tle bit

hudochenkov · 2017-02-16T11:59:20Z

Benchmarks for ac40d7a

Before:

> stylelint@7.8.0 benchmark-rule /Users/aleks/projects/stylelint
> node scripts/benchmark-rule.js "declaration-block-no-shorthand-property-overrides" "true"

Warnings: 0
Mean: 45.400157870370364 ms
Deviation: 11.06851959653398 ms

Mean: 41.5444920952381 ms
Deviation: 11.320279370467999 ms

Mean: 41.935588403508774 ms
Deviation: 10.520627666926606 ms

Mean: 41.81118664912281 ms
Deviation: 11.763514223194033 ms

Mean: 41.28931149206349 ms
Deviation: 10.750820788142141 ms

After:

Warnings: 0
Mean: 40.35173133620689 ms
Deviation: 10.237891375944221 ms

Mean: 43.27671090243902 ms
Deviation: 11.477326149577069 ms

Mean: 40.06621774358975 ms
Deviation: 11.043813336306489 ms

Mean: 40.419671480620174 ms
Deviation: 12.434897384556843 ms

Mean: 42.71238819642859 ms
Deviation: 9.455533365058331 ms

Mean: 39.48838472435897 ms
Deviation: 10.162578651704262 ms

…lock-no-shorthand-property-overrides

…ttle bit

…ides

davidtheclark

@hudochenkov Nice work! Left a few comments.

davidtheclark · 2017-02-16T14:36:32Z

lib/rules/declaration-block-no-redundant-longhand-properties/README.md

+-   `grid-template`
+-   `outline`
+-   `text-decoration`
+-   `text-emphasis`


Wow, this is a lot of new power!

This PR is looking great!

davidtheclark · 2017-02-16T14:37:05Z

lib/rules/declaration-block-no-shorthand-property-overrides/index.js

+      }
+
+      check(node)
+    })


Why is this change relevant?

It's kind of irrelevant. Benchmarks here. Should I revert this change?

Is this change the only thing that caused the slight speed-up? Does such a change reliably cause speed-ups in other rules? What we had before matches a pattern that is widely used throughout the rules, so I'd prefer to stick with it unless we get some significant benefit from changing it.

davidtheclark · 2017-02-16T14:37:42Z

lib/rules/shorthand-property-no-redundant-values/index.js

@@ -15,7 +14,14 @@ const messages = ruleMessages(ruleName, {
  rejected: (unexpected, expected) => `Unexpected longhand value '${unexpected}' instead of '${expected}'`,
 })

-const shorthandableProperties = new Set(Object.keys(shorthandData))
+const shorthandableProperties = new Set([


Can you please add a comment explaining why these specific properties are checked, and not others?

Done. Not sure if text correct, though. Also added grid-gap. Maybe some other Grid properties can be added, but I can't say for sure.

…lock-no-redundant-longhand-properties

davidtheclark

I just left the one comment about a potentially irrelevant change. Once we address that, I think this is ready to merge, right?

davidtheclark · 2017-02-17T23:58:44Z

lib/rules/declaration-block-no-shorthand-property-overrides/index.js

+      }
+
+      check(node)
+    })


Is this change the only thing that caused the slight speed-up? Does such a change reliably cause speed-ups in other rules? What we had before matches a pattern that is widely used throughout the rules, so I'd prefer to stick with it unless we get some significant benefit from changing it.

jeddy3

LGTM. Thanks!

davidtheclark · 2017-02-18T16:03:14Z

Added to changelog:

Fixed: declaration-block-no-redundant-longhand-properties and declaration-block-no-shorthand-property-overrides understand more shorthand properties (#2354).

* Add stylelint semantic versioning policy * Fix whitespace and empty lines * Add changelog entry * Remove stylelint-config=standard reference * Tweak major release optional options verbiage * Update changelog * Props ESLint * Fix false negatives with ignore: ["descendant"] in selector-no-type (#2200) * Update CHANGELOG.md * Fix handling of shared-line comments (#2262) * Fix handling of shared-line comments Introduces a number of utilities and adjusts the following rules: at-rule-empty-line-before, custom-property-empty-line-before, declaration-empty-line-before, rule-nested-empty-line-before, rule-non-nested-empty-line-before Closes #2237; closes #2239; closes #2240. * Fixes based on feedback * Use getPreviousNonSharedLineCommentNode more * Use more new helpers in comment-empty-line-before * Add ignore: ["child"] option to selector-no-type (#2217) * Add ignore: ["child"] option to selector-no-type * Correct logic for ignore: ["child"] option * Include line and column in reject tests with multiple type selectors * Update CHANGELOG.md * Report every selector resolved selector in selector-max-compound-selectors (#2350) * Update CHANGELOG.md * Add new shorthand data (#2354) * Add new shorthand data * Add mask shorthand * Use defined list of properties in shorthand-property-no-redundant-values * Improve declaration-block-no-shorthand-property-overrides speed a little bit * Check prefixed properties agains prefixed properties in declaration-block-no-shorthand-property-overrides * Improve declaration-block-no-redundant-longhand-properties speed a little bit * Ignore prefixes case in declaration-block-no-shorthand-property-overrides * Check prefixed properties agains prefixed properties in declaration-block-no-redundant-longhand-properties * Add `grid-gap` to shorthand-property-no-redundant-values * Explain properties set for shorthand-property-no-redundant-values * Revert unnecessary changes * Add “mask” to declaration-block-no-redundant-longhand-properties readme * Update CHANGELOG.md * Update changelog * Remove deprecated rules (#2422) * Remove deprecated rules * Include `rule-empty-line-before` in system tests * *-empty-line-before rules consider line as empty if it contains whitespace only (#2440) * Update CHANGELOG.md * Remove deprecated options (#2433) * Update CHANGELOG.md * report-needless-disables now exits with non-zero code (#2341) * Update CHANGELOG.md * Remove leftover files (#2442) * Remove leftover file * One more * And one more * Ignoring improvements (#2464) * WIP ignoring improvements * Remove standaloneIgnored property of result * Add disableDefaultIgnores * Add documentation tweaks * Add parseStylelintIgnore tests * Non-absolutized ignore file paths * Restire gitignore syntax * Remove parseStylelintIgnore * Update CHANGELOG.md * Check all linear-gradients in a value list (#2496) Closes #2481 * Update CHANGELOG.md * Update CHANGELOG.md * Respect line case for `ignorePattern` (#2683) Closes #2647 * Update CHANGELOG.md * Update decls * Fix remark warning * Update snapshots * Add missing message to reject test * Fix tests for *-empty-line-before rules (#2688) * Fix tests for *-empty-line-before rules * Test addition and tweak * Update to PostCSS@6 (#2561) * Update to PostCSS@6 * Fix PostCSS@6 closing-brace test (#2689) * Account for PostCSS@6's support for at-apply * Remove only * Fix postcssPlugin tests (#2690) * Fix defaultSeverity.test.js test * Fix ignoreDisables test * Check ownSemiColon * Fixed: remove hacks related to custom property set. * Remove deprecated rules (#2693) Closes #2521 * Update CHANGELOG.md * Update CHANGELOG.md * Add VISION.md (#2704) * Add releases.md (#2705) * Add releases.md Closes #2700 * Add dry-release step * Use HTTPS for links * Change ignore options for selector-max-type (#2701) * Fix false negatives with ignore descendant * Add ignore child Closes #2699 * Update CHANGELOG.md * Update README.md to account for VISION.md (#2727) * Update README.md to account for VISION.md * Fix lint warnings in CHANGELOG * Update postcss-less to 1.0 (#2702) * Update postcss-less to 1.0.2 * Update isStandardSyntaxRule for postcss-less 1.0 * Pass custom postcss stringifier when creating result * Correct no-extra-semicolons Less test position * Ignore Less mixins in no-extra-semicolons * Update postcss-less to 1.1.0 * Correct no-extra-semicolons Less test position again * Utilize isStandardSyntaxRule when checking for Less rules in no-extra-semicolons * Case sensitive white/blacklists and ignore* options (#2709) Closes #2660 * Update CHANGELOG.md * docs: Add "New Release Issue Template" to releases.md (#2728) * Exit with non-zero code on postcss warnings (#2713) * Enhancement: exit with non zero code on postcss warnings. * Account for parseErrors in stringformatqer * Guard against no parseErrors * Update CHANGELOG.md * Refactor: simplify ignore logic. (#2732) * Update changelog * Bump 8.0.0 changes to top * Correctly place changelog items * Add introduction * Add codefence for website * Use relative path * Include VISION in package for website * Add link to VISION doc for website * Changelog amends * Update releases.md (#2738) * Update eslint and config (#2737) * Order requires * Use eqeqeq eslint rule * Update eslint * Disable no-useless-escape just for this repo * Enable no-useless-escape rule * Use tilde * Fix enable comment * Add reject test for unescaped regex

Add new shorthand data

027d73e

hudochenkov added the PR: review needed label Feb 12, 2017

hudochenkov added 2 commits February 12, 2017 18:06

Add mask shorthand

b1d33b4

Use defined list of properties in shorthand-property-no-redundant-values

ee8f75f

hudochenkov added PR: needs revision and removed PR: review needed labels Feb 12, 2017

Improve declaration-block-no-shorthand-property-overrides speed a lit…

ac40d7a

…tle bit

hudochenkov added 3 commits February 16, 2017 15:54

Check prefixed properties agains prefixed properties in declaration-b…

35a1a4f

…lock-no-shorthand-property-overrides

Improve declaration-block-no-redundant-longhand-properties speed a li…

2012d28

…ttle bit

Ignore prefixes case in declaration-block-no-shorthand-property-overr…

2514dd0

…ides

davidtheclark suggested changes Feb 16, 2017

View reviewed changes

hudochenkov added 3 commits February 16, 2017 18:14

Check prefixed properties agains prefixed properties in declaration-b…

b0eae73

…lock-no-redundant-longhand-properties

Add grid-gap to shorthand-property-no-redundant-values

fc466a9

Explain properties set for shorthand-property-no-redundant-values

292f3a1

davidtheclark reviewed Feb 18, 2017

View reviewed changes

hudochenkov added 2 commits February 18, 2017 10:46

Revert unnecessary changes

15c8a58

Add “mask” to declaration-block-no-redundant-longhand-properties readme

4d7136a

jeddy3 added PR: review needed and removed PR: needs revision labels Feb 18, 2017

jeddy3 approved these changes Feb 18, 2017

View reviewed changes

davidtheclark approved these changes Feb 18, 2017

View reviewed changes

davidtheclark merged commit c3aedd1 into v8 Feb 18, 2017

davidtheclark deleted the new-shorthand-data branch February 18, 2017 16:01

davidtheclark mentioned this pull request Feb 18, 2017

False negatives for some properties in declaration-block-no-redundant-longhand-properties and declaration-block-no-shorthand-property-overrides #1780

Closed

jeddy3 added the PR: review accepted label Feb 19, 2017

jeddy3 removed the PR: review needed label Feb 19, 2017

dependencies bot mentioned this pull request Jan 24, 2018

Update stylelint in /packages/generator/app/templates from 7.11.1 to 8.0.0 JetBrains/ring-ui#88

Merged

dependabot-preview bot mentioned this pull request Mar 14, 2018

Bump stylelint from 7.10.1 to 9.1.2 nathanmsmith/RadioxDB-flatpage#26

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new shorthand data #2354

Add new shorthand data #2354

hudochenkov commented Feb 12, 2017

davidtheclark commented Feb 12, 2017

hudochenkov commented Feb 12, 2017

davidtheclark commented Feb 12, 2017

hudochenkov commented Feb 16, 2017

davidtheclark left a comment

davidtheclark Feb 16, 2017

jeddy3 Feb 16, 2017

davidtheclark Feb 16, 2017

hudochenkov Feb 16, 2017

davidtheclark Feb 17, 2017

hudochenkov Feb 18, 2017

davidtheclark Feb 16, 2017

hudochenkov Feb 16, 2017

davidtheclark left a comment

davidtheclark Feb 17, 2017

jeddy3 left a comment

davidtheclark commented Feb 18, 2017

Add new shorthand data #2354

Add new shorthand data #2354

Conversation

hudochenkov commented Feb 12, 2017

davidtheclark commented Feb 12, 2017

hudochenkov commented Feb 12, 2017

davidtheclark commented Feb 12, 2017

hudochenkov commented Feb 16, 2017

davidtheclark left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davidtheclark left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeddy3 left a comment

Choose a reason for hiding this comment

davidtheclark commented Feb 18, 2017