Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: descendant combinator in selector-descendant-combinator-no-non-space and selector-combinator-space-before/after #2509

Merged

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Apr 18, 2017

Which issue, if any, is this issue related to?

#2506

Is there anything in the PR that needs further explanation?

No, it's self explanatory.

…ort on shadow-piercing descendant combinator.
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add brief tests to selector-combinator-space-after and selector-combinator-space-before please. They also make sure of lib/reference/punctuationSets.js, and should be fine.

@alexander-akait
Copy link
Member Author

@jeddy3 I'm right now take their implementation (btw i think drop styleSearch in this rules and use postcss-selector-parser)

@jeddy3
Copy link
Member

jeddy3 commented Apr 18, 2017

(btw i think drop styleSearch in this rules and use postcss-selector-parser)

Let's only do that if it adds something e.g. clarity or performance etc.

If the selector-combinator-space-* rules work for >>> with a simple change the punctuation reference, then let's stick with that for now.

@alexander-akait
Copy link
Member Author

@jeddy3 not working as expected because we have > and >>> and styleSearch found > 😭

@alexander-akait alexander-akait changed the title Fixed: selector-descendant-combinator-no-non-space is not don't rep… Fixed: selector-descendant-combinator-no-non-space is not don't report on shadow-piercing descendant combinator Apr 18, 2017
…ce-before` is now support `>>>` shadow-piercing descendant combinator.
@alexander-akait alexander-akait changed the title Fixed: selector-descendant-combinator-no-non-space is not don't report on shadow-piercing descendant combinator Fixed: descendant combinator in selector-descendant-combinator-no-non-space and selector-combinator-space-before/after Apr 18, 2017
@alexander-akait
Copy link
Member Author

Sorry for big commit, but i think it should be done together
One note: selector-combinator-space-before/after don't support /deep/ (and other reference selectors) (because postcss-selector-parse don't works with their, theoretically we can write isReferenceSelector). I think we can leave this commit as it is and next commit i can see how handle reference selectors in this rules (maybe need see other rules).

/cc @jeddy3

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeddy3
Copy link
Member

jeddy3 commented Apr 19, 2017

One note: selector-combinator-space-before/after don't support /deep/ (and other reference selectors)

Yes, that's fine. Enforcing spacing around /deep/ will need to be a separate issue as it's a breaking change - feel free to create a new issue for this. The changes in this PR are fixes so that >>> isn't mistaken for >.

@alexander-akait
Copy link
Member Author

@jeddy3 it think issue already created #2506, even the name it shows 😄

@davidtheclark davidtheclark merged commit 484b135 into master Apr 22, 2017
@davidtheclark davidtheclark deleted the issue-2506-selector-descendant-combinator-no-non-space branch April 22, 2017 18:02
@davidtheclark
Copy link
Contributor

Added to changelog:

  • Fixed: selector-descendant-combinator-no-non-space and selector-combinator-space-before/after now understand and check >>> shadow-piercing combinator (#2509).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants