Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle plurals consistently in messages #2663

Merged
merged 1 commit into from
Jun 21, 2017
Merged

Handle plurals consistently in messages #2663

merged 1 commit into from
Jun 21, 2017

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Jun 20, 2017

Closes #2655

hudochenkov
hudochenkov approved these changes Jun 21, 2017
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jeddy3 jeddy3 merged commit 6f78fef into master Jun 21, 2017
@jeddy3 jeddy3 deleted the max-rule-messages branch June 21, 2017 11:05
@jeddy3
Copy link
Member Author

jeddy3 commented Jun 21, 2017

Changelog:

  • Fixed: max-* rules now use singular and plural nouns in their messages (#2663).

@renovate renovate bot mentioned this pull request Jun 26, 2017
Merged
@dependabot-preview dependabot-preview bot mentioned this pull request Mar 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeddy3 @hudochenkov @alexander-akait