Ignore nested non-standard selectors in selector-max-specificity #2685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudochenkov
reviewed
Jun 27, 2017
| @@ -12,6 +12,8 @@ Visit the [Specificity Calculator](https://specificity.keegan.st) for visual rep | |||
|
|
|||
| This rule ignores selectors with variable interpolation (`#{$var}`, `@{var}`, `$(var)`). | |||
|
|
|||
| This rule ignores all selectors, standard syntax or otherwise, nested within non-standard rule constructs e.g. `@each`. | |||
There was a problem hiding this comment.
I can't understand this sentence :(
There was a problem hiding this comment.
I pulled this out as I think the preceding statement is good enough:
This rule ignores selectors with variable interpolation (
#{$var},@{var},$(var)).
I'm afraid not as we don't have a heuristic in |
alexander-akait
approved these changes
Jun 27, 2017
hudochenkov
approved these changes
Jun 29, 2017
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2684