Image mixin refactor #277
Closed
Image mixin refactor #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves the issue outlined in LearnBoost/stylus#1678, using code supplied in a comment to that ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue outlined in #276.
The image mixin fails when nested inside a media query, and this pull request resolves that issue using code supplied in the associated Stylus ticket.
An additional test has been written for this case, and all tests are passing based on the current Stylus dependency.
Note that this outputs nested media queries, whereas using 0.48.1 results in flattened media queries. I would update the dependency and test case output file but an additional test related to linear gradients also fails when using latest Stylus.