Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Tape recording debug mode #2442

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

[WIP] Tape recording debug mode #2442

wants to merge 11 commits into from

Conversation

oleburghardt
Copy link
Contributor

Proposed Changes

Add feature to record a tape for debug purposes (as a tool for AD / discrete adjoint / .. developers), using CoDiPack's codi::RealReverseTag.

This is a (cleaned-up) continuation of #2343.

Related Work

Supposed to help finding remaining errors in #2317.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@oleburghardt
Throw error message in case the multizone discrete adjoint solver wil…
fffbc97 
…l write restart files during runtime (there is a bug, potentially when clearing the tape).
@oleburghardt
Softcode indentifier/index.
ba6ee1c
@oleburghardt
Add tag type option to build system.
c54597b
@oleburghardt
Add option to use RealReverseTag as AD type.
a24fc80
@oleburghardt
Temporarily adjust/hardcode type size for memory alignment in vectori…
263faa0 
…zation.hpp (to cover RealReverseTag).
@oleburghardt
Add config option and indicator for a debug discrete adjoint run.
11d34b3
@oleburghardt
Add routines for setting tags to AD structure.
756dc57
@oleburghardt
Add kinds of recording for tag tapes.
b1e4f69
@oleburghardt
Comment out checks in AD structure whether an identifier is active. T…
cc7b0cf 
…his is a temporary change to avoid false positives when a tag tape is used. They might be unnecessary anyway though.
@oleburghardt
Add first WIP version of the tag debug mode to the (multizone) discre…
44cde90 
…te adjoint solver.
@oleburghardt
Revert small change (will be added to CoDi soon).
0bbd832
@oleburghardt oleburghardt mentioned this pull request Feb 11, 2025
Closed
6 tasks
@oleburghardt oleburghardt changed the title Tape/Recording debug mode [WIP] Debug tape recording mode Feb 11, 2025
@oleburghardt oleburghardt changed the title [WIP] Debug tape recording mode [WIP] Tape recording debug mode Feb 11, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 11, 2025
View reviewed changes
Common/include/basic_types/ad_structure.hpp
@@ -515,9 +536,9 @@
FORCEINLINE void SetPreaccIn(const T& data, const int size) {
if (PreaccActive) {
for (int i = 0; i < size; i++) {
if (IsIdentifierActive(data[i])) {
// if (IsIdentifierActive(data[i])) {

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Common/include/basic_types/ad_structure.hpp
PreaccHelper.addInput(data[i]);
}
// }

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Common/include/basic_types/ad_structure.hpp
@@ -527,9 +548,9 @@
if (!PreaccActive) return;
for (int i = 0; i < size_x; i++) {
for (int j = 0; j < size_y; j++) {
if (IsIdentifierActive(data[i][j])) {
// if (IsIdentifierActive(data[i][j])) {

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Common/include/basic_types/ad_structure.hpp
PreaccHelper.addInput(data[i][j]);
}
// }

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Common/include/basic_types/ad_structure.hpp
SetPreaccOut(moreData...);
}

template <class T>
FORCEINLINE void SetPreaccOut(T&& data, const int size) {
if (PreaccActive) {
for (int i = 0; i < size; i++) {
if (IsIdentifierActive(data[i])) {
// if (IsIdentifierActive(data[i])) {

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Common/include/basic_types/ad_structure.hpp
PreaccHelper.addOutput(data[i]);
}
// }

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Common/include/basic_types/ad_structure.hpp
@@ -567,9 +589,9 @@
if (!PreaccActive) return;
for (int i = 0; i < size_x; i++) {
for (int j = 0; j < size_y; j++) {
if (IsIdentifierActive(data[i][j])) {
// if (IsIdentifierActive(data[i][j])) {

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Common/include/basic_types/ad_structure.hpp
PreaccHelper.addOutput(data[i][j]);
}
// }

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
SU2_CFD/src/drivers/CDiscAdjMultizoneDriver.cpp
cout << " Objective function : " << ObjFunc;
if (driver_config->GetWrt_AD_Statistics()){
cout << " (" << ObjFunc_Index << ")\n";
// cout << " (" << ObjFunc_Index << ")\n";

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oleburghardt