[Perl] Small whitespace related improvements #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The accessor `::` may be surrounded by spaces and tabs. Not sure whether someone makes use of tabs in such situations, but it should not fail if one decides to do so. HEREDOC indention still accepts normal spaces only at the moment as the amount of spaces in front of the starting and terminating keyword must be the same which might be tricky to handle if mixed indention is used.
Inspired by PR sublimehq#1640 this commit removes the isolated (?x) from the `pragma` context. Even though no related issues were found this style of flag is used in the `functions` context already. So this change ensures the same coding style to be used in both contexts.
|
Could we add a test for this? |
|
Basically there are already some tests about accessors surrounded by whitespace, but a second look revealed some pragma keywords like |
|
Thanks! |
charlievieth
pushed a commit
to charlievieth/Packages
that referenced
this pull request
Jul 25, 2018
* [Perl] Allow any kind of whitespace around accessors The accessor `::` may be surrounded by spaces and tabs. Not sure whether someone makes use of tabs in such situations, but it should not fail if one decides to do so. HEREDOC indention still accepts normal spaces only at the moment as the amount of spaces in front of the starting and terminating keyword must be the same which might be tricky to handle if mixed indention is used. * [Perl] Remove an isolated regexp flag Inspired by PR sublimehq#1640 this commit removes the isolated (?x) from the `pragma` context. Even though no related issues were found this style of flag is used in the `functions` context already. So this change ensures the same coding style to be used in both contexts.
deathaxe
added a commit
to deathaxe/sublime-packages
that referenced
this pull request
Jun 9, 2019
* [Perl] Allow any kind of whitespace around accessors The accessor `::` may be surrounded by spaces and tabs. Not sure whether someone makes use of tabs in such situations, but it should not fail if one decides to do so. HEREDOC indention still accepts normal spaces only at the moment as the amount of spaces in front of the starting and terminating keyword must be the same which might be tricky to handle if mixed indention is used. * [Perl] Remove an isolated regexp flag Inspired by PR sublimehq#1640 this commit removes the isolated (?x) from the `pragma` context. Even though no related issues were found this style of flag is used in the `functions` context already. So this change ensures the same coding style to be used in both contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies a change inspired by @keith-hall to avoid possibly breaking the
breakvariable if it is used in extended regex patterns. It includes surrounding the::by tabs as well.The second commit turns an
(?x)into an(?x: ...as the latter one was used in another context the same way like.