Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQL] use inheritance to support different dialects #3046
base: master
Are you sure you want to change the base?
[SQL] use inheritance to support different dialects #3046
Changes from 3 commits
09f5a6e
841225c
666c89e
2227515
daca95f
2536946
91b2f89
245c748
696bc38
82f6060
a527926
ea42460
e92279b
9067ab5
e9ffa2d
c283637
700f8f8
7224d18
ff347d1
076427b
0d66768
6e3c84c
adaaf66
488ee10
73c8870
caa1cb7
6c4ffea
0c3df74
843f708
16e9e12
545ddcb
edb2e68
a305dc7
8940b18
ae58314
a4754f4
bdd4b7e
e246202
ee8a3f5
22a8677
d3357e8
ac08fc6
5350f07
9f56575
3c4eeaf
fdcbe5e
478d1ac
7e72cf5
3470a3d
454877f
67f8cb5
bc9e021
0dfb869
2ef35ee
6f903b5
5e130b9
ee39f29
a49f534
c6d4ccc
c7ada36
4c207bc
29cb4a9
ad5e59f
aac3833
acfbeeb
5868db6
511206a
548752d
f586ddc
7d7fe03
29320a9
ef8716b
b4e0456
301bddf
e8eee03
cf0bed6
4ca8ec5
9f10f81
27a6a5f
db1faa0
e2de580
3f82531
998f7a1
b941956
a3b4290
86ac1c4
6d68d53
6f32bbe
e0c8b41
02123eb
c25d4dd
f6965b9
ad6c269
c6e3dcd
db7dad4
472603b
e73d683
a6087e1
7f11859
b0a5c05
f6f10ef
23708c7
bc14941
1471890
bc056c9
b23344c
4c84c20
ed8cb47
5597b02
9c56e2e
9d539e1
ae27fa1
49d6ad8
26a1ea5
0607a8b
e4e0bc2
45a616d
0711ff9
7ee6154
543c1eb
e6ee23f
6d913dc
9e4dbf3
0ed3589
a58db1d
286372c
3e58cb8
0799802
10e4c1e
4cc98a3
f8c096d
7006e54
3ea6eb0
5369bbb
969fcd1
4278b99
257cba7
9476e36
ad140af
bb5d3e9
7f7daf6
a03ac2f
d2dd962
cb17a71
da874e9
df5be4c
dae0ec0
d7ab07f
1d21f06
d324986
5707b4f
6f9e8cb
90096a5
d9e2f22
5e3e28a
59641a2
dd8a9bd
4268bb6
866e570
3b02297
3dce643
e9341b0
a13c93d
ae8b1ce
ff5f685
b6960a6
9e4e60c
59c0d87
3ac3b2d
253037d
412bf15
0fdce03
5fe0636
f7cd539
dab0197
f88d5a8
9b67bd8
ebca675
b26f93d
33c5a06
1fef6f9
990b166
fb8ef15
733265f
d67c718
a99b7ea
edb2cc7
dc1185a
128b16f
fce8721
a1337d7
c92f79a
5628ec1
436ba5a
aeb3ce6
42b187c
649b960
02161ef
7e834cd
59d96d8
880068a
8073d9d
f7fffad
cf6f640
a107580
bc5af53
272041d
5b1f29d
5b2d73d
8d22bf3
42ea97d
b574398
cc2a871
1f5edee
d55ba7c
071f96b
1cf5566
9176138
2c29093
ec6fdc6
ae2f0da
f04117c
245a439
3205950
dcc2a93
d79bcbe
ced5671
d837ea3
9ab469d
6dcaafe
24583c3
6a0de68
c49b7f8
5d51874
a4bad73
734d51d
b639a41
7477d3f
88751b5
d7c0650
f05d8fa
a2205e9
827b729
1c49ea3
e4923a6
7abb7f4
ed66b5e
b571b85
fd38f1e
2efa4a8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I am wrong but does string interpolation in SQL behave the same as normal string interpolations like Python, C# etc. ? If so, then shouldn't this be
punctuation.definition.interpolation.begin.sql
(If so perhaps have a separate scope for leading%
aspunctuation.definition.interpolation.sql
?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I have no idea how interpolations work in MySql. My plan was just to leave it as it is (i.e. before this PR) in the hope that someone with more experience can improve upon it later.