[Regular Expressions] Add support for quoted find path patterns #3816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brackets are just not evaluated as character classes. It doesn't mean they are illegal. It is very ok for folder names to contain brackets.
This commit aligns file name with the replace pattern test file.
This commit... 1. updates syntax to version 2 2. adds support for quoted path patterns 3. adds dedicated set of contexts for both kinds of patterns to correctly distinct wildcard scopes, depending on their usage. That's required because ST treats `*` differently, depending on whether `/` is present in a pattern or not and users request distinct scopes for being able to apply different colors. color schemes can use: - meta.file.file-pattern constant.other.wildcard - meta.path.file-pattern constant.other.wildcard
This commit moves all syntax tests to a "tests" sub directory to follow the scheme of other syntax packages in this repo.
|
I have been misreading the documentation for years. 🤦♂️ |
jfcherng
approved these changes
Aug 3, 2023
michaelblyons
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors File Pattern.sublime-syntax to
add support for quoted path patterns (e.g.:
"//my/path with,comma/*")distinguish path patterns and file patterns using meta scopes, so color schemes can choose separate highlighting for wildcards depending on their function, despite using the same
constant.other.wildcardscope in both./or\, are scopedmeta.path.file-pattern*.pyare scopedmeta.file.file-patternmoves syntax tests to a sub directory