Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSS] Add support for container at-rule #3819

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

deathaxe
Copy link
Collaborator

@deathaxe deathaxe commented Aug 3, 2023

This PR adds support for @container <name> <query> { <rules> }.

It's fully supported by all current browsers.

see:

@deathaxe deathaxe merged commit 0a97be5 into sublimehq:master Aug 4, 2023
2 checks passed
@deathaxe deathaxe deleted the pr/css/at-container branch August 4, 2023 07:50
@amdd-tim
Copy link

amdd-tim commented Jan 6, 2024

This says 'Approved' but I'm not seeing the syntax highlighting for the container at-rule on Build 4169. Am I missing something?

@michaelblyons
Copy link
Collaborator

You can follow the steps in the ReadMe to get it now, or you can wait until an official ST release with a changelog message that says "updated syntax highlighting" or something.

@amdd-tim
Copy link

amdd-tim commented Jan 7, 2024

@michaelblyons thanks. Thought maybe since this was merged before the last Sublime build (4169 24 November 2023), that it might have been included and I was missing something.

@deathaxe
Copy link
Collaborator Author

deathaxe commented Jan 7, 2024

It should have been.

@amdd-tim
Copy link

amdd-tim commented Jan 7, 2024

@deathaxe okay so I am missing something? The changelog in the app does skip build numbers, but I was assuming having the most recent build would have all the most recent changes, even if I wasn't updating every build.
Screenshot 2024-01-07 at 10 21 56 AM

@amdd-tim
Copy link

amdd-tim commented Jan 7, 2024

Ah, nevermind. I'm seeing it now. Sorry for the false alarm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants