[TypeScript] Implement labeled tuple members #3837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
C# and Python support named tuples, it may make sense to check what scopes they use |
This commit ... 1. optimizes implementation to speed it up by about 15% 2. rescopes labels to `variable.other.member` as variable scope is what C# uses and this is what labels are for. Create named access to tuple members as if they were normal struct members. Note: 1. `meta.mapping.key` should be used in mappings only. 2. We shouldn't mix up sequence and mapping scopes, although a mapping is just a sequence of key-value pairs.
|
Sorry, for directly pushing. I wanted to create a PR to this PR, but Sublime Merge decided to not give me an option to push it to my local repo, but decided to directly push it here. |
|
LGTM. |
deathaxe
approved these changes
Sep 23, 2023
michaelblyons
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g.
type Rational = [numerator: bigint, denominator: bigint];Introduced in TypeScript 4.0 more than three years ago, but documented nowhere outside those release notes (plus the recent 5.2 release notes).
I used the scope
meta.mapping.keyfor the labels, which doesn't seem quite right but I don't know what would be more right.The implementation uses branching because a lookahead would have to span multiple lines. I initially intended to use a cover grammar approach, but that would be a mess if the label were the name of a type operator (which you would think wouldn't be allowed, but here we are).