[TypeScript] Keyword types can't be generic #3863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Put back generic parameters in namespaced types. Also added some plain-TS tests for those, which were apparently overlooked. |
jrappen
approved these changes
Oct 31, 2023
deathaxe
approved these changes
Oct 31, 2023
michaelblyons
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3862.
Originally, type arguments were part of the regular type expression structure, so the syntax would try to highlight type arguments after any type. But actually, only ordinary named types can get them. In the linked issue, this was causing problems with
as-style type assertions — when followed by a<, the type expression was eating it and trying to parse type arguments, even when the preceding type does not accept them.According to the spec — I'm kidding, we all know the drill by now, actually after a bunch of futzing around in AST Explorer — this should work correctly in all cases I can think of.
In order for this to work in all cases, it's necessary to ensure that all specially keyworded types are accounted for, so this PR also adds the
trueandfalsesingleton types.