[JavaScript] Fix infinite loop caused by diff conflict markers #4046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses sublimehq/sublime_text#6498 This commit restricts JSX tag matching to avoid infinite loops, caused by invalid syntax, which is still recognized as potential JSX content, but may cause heavy backtracking due to unmatched tags. With this commit `<` is expected to be followed by either a valid jsx-tag-name or tag-end punctuation on the same line to be consumed as jsx tag.
michaelblyons
approved these changes
Sep 28, 2024
FichteFoll
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses sublimehq/sublime_text#6498
This commit restricts JSX tag matching to avoid infinite loops, caused by invalid syntax, which is still recognized as potential JSX content, but may cause heavy backtracking due to unmatched tags.
With this commit
<is expected to be followed by either a valid jsx-tag-name or tag-end punctuation on the same line to be consumed as jsx tag.