[Rust] Add + use<> syntax
#4139
Conversation
| - match: '<' | ||
| scope: punctuation.definition.generic.begin.rust | ||
| set: | ||
| - match: '>' |
There was a problem hiding this comment.
I'd suggest to add a meta scope to generics.
| - match: '>' | |
| - match: '>' | |
| - meta_scope: meta.generic.rust |
| - match: \b(Self)\b | ||
| scope: keyword.other.rust | ||
| - match: '{{identifier}}' |
There was a problem hiding this comment.
Self is already defined as storage type in no-path-type-names context and identifiers should also receive valuable scope names. Types are currently unscoped as other identifiers are.
I'd therefore suggest to include ordinary identifiers context, which would also - even if maybe not required - handle fully qualified identifiers.
| - match: \b(Self)\b | |
| scope: keyword.other.rust | |
| - match: '{{identifier}}' | |
| - include: identifiers |
There was a problem hiding this comment.
While it's not be 100% accurate either, I'd rather include types here since that is meant to be used in situations where types are expected. It matches lifetimes as well as stray identifiers and commonly known stdlib types. Alternatively, you could refactor the types context a bit and only include the relevant things for UseBoundGenericArg here, which are lifetimes and (pathed) identifiers (with a type scope).
Commas still need to be matched separately, though.
There was a problem hiding this comment.
Actually, reading the spec properly, pathed identifiers aren't supported and it is also unlikely for built-in names to be used since this is supposed to refer to generics and a generic with a built-in name would shadow it.
In that case, please instead simply include all-generic-type-names.
This adds support for the
+ use<>precise capture syntax to Rust which was introduced in Rust 1.82.Documentation