-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add LSP-rome #1
add LSP-rome #1
Conversation
notes:
1. rome.json options not respected.I have the following function x() {
let d = 21;
} I have the following
When i run format file, this request is send:
and the file gets formatted with function x() {
let d = 21;
} But I expect this: function x() {
let d = 21;
} 2, At some point Rome shows an error for a valid file...This looks like a server issue. I don't know how I managed to trigger it. I guess there is nothing we could do about it, except being aware that it can happen. EDIT: you already opened an issue rome/tools#4094 :) |
It's already present in
Probably because server doesn't advertise support for it. We should investigate whether we should report this in Rome or whether we should align our LSP logic.
Will check it after adding support for using workspace server.
Yep, already reported. |
Ok, it works. I don't know what happened today. It seemed like it didn't work. |
The server relies on format on save. I really wish that they went with code actions on save instead of format on save. |
I can't reproduce "1". My |
I've seen on their Discord channel that the project might be in a bit of a trouble financially and a couple of developers left due to that. Might not have a bright future. |
Thanks for the work! Any chance this will be merged/released any time soon? |
I can merge it. I've noticed that the server might randomly quit because of what I think are some issues in flushing the stdout output. But it's something that would have to be reported to Rome if it keeps happening. |
I've added Also changed default value of Also updated to latest version of the server - 12.1.3 |
TODO