Move all charts into /charts dir #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfarrell07
requested review from
mangelajo,
Oats87 and
tpantelis
as code owners
dfarrell07
force-pushed
the
mv_to_charts_dir
branch
from
79d7cd1 to
3a23af1
Compare
Attempting to get helm/charts-releaser to detect changes to our charts and publish them. It seems the GHA expects this layout. See discussion: helm/chart-releaser-action#36 And default dir: https://github.com/helm/chart-releaser-action/blob/master/action.yml#L14 Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
dfarrell07
force-pushed
the
mv_to_charts_dir
branch
from
3a23af1 to
c9837a4
Compare
|
charts-releaser attempts to create a release if it finds changes, see https://github.com/submariner-io/submariner-charts/pull/89/checks?check_run_id=1396648865 I think we should re-implement the Travis job instead of using charts-releaser. |
|
Closing in favor of #90. |
|
Independent of the releasing question, it still seems we should use a |
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to get helm/charts-releaser to detect changes to our charts
and publish them. It seems the GHA expects this layout.
See discussion:
helm/chart-releaser-action#36
And default dir:
https://github.com/helm/chart-releaser-action/blob/master/action.yml#L14
Signed-off-by: Daniel Farrell dfarrell@redhat.com