Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add healthcheck configuration and RBAC in route agent and register crds #3146

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Add healthcheck configuration and RBAC in route agent and register crds #3146

merged 1 commit into from
Jul 22, 2024

Conversation

aswinsuryan
Copy link
Contributor

@aswinsuryan aswinsuryan commented Jul 5, 2024 •
edited

Add the healthcheker configuration in route agent and give
permission for routegent permission for crud operation of
routeagent resources.

Register the routeagent crds

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr3146/aswinsuryan/route-agent-healthcheck
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@aswinsuryan aswinsuryan force-pushed the route-agent-healthcheck branch 2 times, most recently from abd0fac to 19e994a Compare July 8, 2024 18:14
@aswinsuryan aswinsuryan changed the title Add healthcheck configuration in route agent Add healthcheck configuration and RBAC in route agent Jul 17, 2024
@aswinsuryan aswinsuryan force-pushed the route-agent-healthcheck branch 4 times, most recently from 9b7b8de to 256863e Compare July 19, 2024 16:02
@aswinsuryan aswinsuryan marked this pull request as ready for review July 19, 2024 16:03
@aswinsuryan aswinsuryan force-pushed the route-agent-healthcheck branch 2 times, most recently from 9e42e08 to e6b0cea Compare July 19, 2024 16:32
@tpantelis
Copy link
Contributor

I assume we'll be checking RouteAgent CRs in subctl diagnose so we'll need RBAC permissions here we well.

@aswinsuryan aswinsuryan changed the title Add healthcheck configuration and RBAC in route agent Add healthcheck configuration and RBAC in route agent and register crds Jul 19, 2024
@aswinsuryan
Copy link
Contributor Author

I assume we'll be checking RouteAgent CRs in subctl diagnose so we'll need RBAC permissions here we well.

Done.

@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Jul 22, 2024
@aswinsuryan
Add healthcheck configuration and RBAC in route agent and register crds
ac4d7de 
Add the healthcheker configuration in route agent and give
permission for routegent permission for crud operation of
routeagent resources.

Register the routeagent crds

Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
@tpantelis tpantelis merged commit 37a9d80 into submariner-io:devel Jul 22, 2024
35 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr3146/aswinsuryan/route-agent-healthcheck]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfarrell07 dfarrell07 dfarrell07 approved these changes

@tpantelis tpantelis tpantelis approved these changes

@maayanf24 maayanf24 Awaiting requested review from maayanf24

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@skitt skitt Awaiting requested review from skitt skitt is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

@vthapar vthapar Awaiting requested review from vthapar vthapar is a code owner

@yboaron yboaron Awaiting requested review from yboaron

Assignees
No one assigned
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aswinsuryan @submariner-bot @tpantelis @dfarrell07