Update the copyright statements to match CNCF recs #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Created branch: z_pr1335/skitt/cncf-style-copyright |
skitt
force-pushed
the
cncf-style-copyright
branch
2 times, most recently
from
35d6948 to
5440ec2
Compare
skitt
requested review from
mangelajo,
mkolesnik,
Oats87,
sridhargaddam and
tpantelis
as code owners
skitt
force-pushed
the
cncf-style-copyright
branch
from
5440ec2 to
c3ba1f5
Compare
tpantelis
reviewed
May 19, 2021
.github/workflows/linting.yml
Outdated
| @@ -43,6 +43,9 @@ jobs: | |||
| - name: Check out the repository | |||
| uses: actions/checkout@v2 | |||
|
|
|||
| - name: Delete generated files | |||
| run: rm -rf pkg/client pkg/apis/submariner.io/v1/zz_generated.deepcopy.go pkg/natdiscovery/proto/natdiscovery.pb.go | |||
|
|
|||
There was a problem hiding this comment.
What is this change for?
There was a problem hiding this comment.
Fair question, it’s to avoid checking generated files; but it’s not great, I’m just going to replace the GHA we use instead.
There was a problem hiding this comment.
We need to ignore generated files for some part of the license checks; hopefully it’s clearer in the updated version.
skitt
force-pushed
the
cncf-style-copyright
branch
5 times, most recently
from
9661bd9 to
35ecb1f
Compare
This updates the copyright statements to match the CNCF recommendation, as per https://github.com/cncf/foundation/blob/master/copyright-notices.md We also add SPDX headers, and add enforcement (ignoring generated files which don't carry our copyright). The change in copyright statement is only made to Red Hat statements. Change automated with (split over multiple lines for the commit message): find . -name \*.go -exec sed -i -E \ 's/© .... Red Hat, Inc. and others.?/ SPDX-License-Identifier: Apache-2.0\n\n Copyright Contributors to the Submariner project./' {} + Fixes: submariner-io#1322 Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt
force-pushed
the
cncf-style-copyright
branch
from
9ab979a to
2e96396
Compare
tpantelis
approved these changes
May 20, 2021
dfarrell07
approved these changes
May 20, 2021
tpantelis
approved these changes
May 20, 2021
|
🤖 Closed branches: [z_pr1335/skitt/cncf-style-copyright] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the copyright statements to match the CNCF
recommendation, as per
https://github.com/cncf/foundation/blob/master/copyright-notices.md
We also add SPDX headers, and add enforcement (which is expected to
fail currently).
The change in copyright statement is only made to Red Hat statements.
Change automated with (split over multiple lines for the commit
message):
find . -name *.go -exec sed -i
's/© .... Red Hat, Inc. and others.?/
SPDX-License-Identifier: Apache-2.0\n\n
Copyright Contributors to the Submariner project./' {} +
Fixes: #1322
Signed-off-by: Stephen Kitt skitt@redhat.com