Add pull request template #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a template for PRs with tips and pointers to docs. This completes a recommendation of the CII Best Practices program: > It is SUGGESTED that this policy on adding tests (see test_policy) be documented in the instructions for change proposals. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
|
🤖 Created branch: z_pr1342/dfarrell07/pr_template |
dfarrell07
requested review from
mangelajo,
Oats87,
skitt and
tpantelis
as code owners
|
One issue with this, maybe something to fix/extend, is that I think the commit message (if there's only one) will not be provided as the default PR message, which is quite helpful IMHO. |
tpantelis
approved these changes
May 19, 2021
nyechiel
approved these changes
May 20, 2021
mangelajo
approved these changes
May 20, 2021
skitt
approved these changes
May 20, 2021
|
🤖 Closed branches: [z_pr1342/dfarrell07/pr_template] |
|
Actually this works even better than I expected, the commit message is still provided as a default. 🥳
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a template for PRs with tips and pointers to docs.
This completes a recommendation of the CII Best Practices program:
Depends on: submariner-io/submariner-website#515
Signed-off-by: Daniel Farrell dfarrell@redhat.com