Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CII badge, remove PR-triggered badges #1343

Merged
merged 1 commit into from
May 20, 2021

Conversation

dfarrell07
Copy link
Member

Add Submariner's CII Best Practices badge to the README.

Remove badges for workflows triggered by PRs, as their status reflects
tests against proposed/WIP code, not merged code. This causes false red
flags, reducing the utility of the badges overall. Leave badges for
workflows run against merged code.

Signed-off-by: Daniel Farrell dfarrell@redhat.com

Add Submariner's CII Best Practices badge to the README.

Remove badges for workflows triggered by PRs, as their status reflects
tests against proposed/WIP code, not merged code. This causes false red
flags, reducing the utility of the badges overall. Leave badges for
workflows run against merged code.

Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
@dfarrell07 dfarrell07 added this to the 0.10-m1 milestone May 19, 2021
@dfarrell07 dfarrell07 self-assigned this May 19, 2021
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1343/dfarrell07/refact_badges

@dfarrell07 dfarrell07 marked this pull request as ready for review May 19, 2021 15:57
@dfarrell07 dfarrell07 mentioned this pull request May 19, 2021
87 tasks
@mangelajo mangelajo merged commit 90763a5 into submariner-io:devel May 20, 2021
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr1343/dfarrell07/refact_badges]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants