Add route-agent-healthcheck

[aswinsuryan]

Add route-agent-healthcheck

[submariner-bot]

🤖 Created branch: z_pr3077/aswinsuryan/route-agent-health-checker
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

[tpantelis]

I know this is still a draft but I took a cursory look at it. It seems you're trying to incorporate route agent ping info into the Gateway CR however I don't think we should do this. I think it makes sense to introduce a similar RouteAgent CR corresponding to each route agent pod, eg:

type RouteAgent struct {
	metav1.TypeMeta   `json:",inline"`
	metav1.ObjectMeta `json:"metadata,omitempty"`
	Status            RouteAgentStatus `json:"status"`
}

type RouteAgentStatus struct {
	Version       string       `json:"version"`
	StatusFailure string       `json:"statusFailure"`
	RemoteEndpoints   []RemoteEndpoint `json:"remoteEndpoints"`
}

type RemoteEndpoint struct {
	Status        ConnectionStatus `json:"status"`
	StatusMessage string           `json:"statusMessage"`
	Spec      EndpointSpec     `json:"endpoint"`
	// +optional
	LatencyRTT *LatencyRTTSpec `json:"latencyRTT,omitempty"`
}

[aswinsuryan]

I know this is still a draft but I took a cursory look at it. It seems you're trying to incorporate route agent ping info into the Gateway CR however I don't think we should do this. I think it makes sense to introduce a similar RouteAgent CR corresponding to each route agent pod, eg:

type RouteAgent struct {
	metav1.TypeMeta   `json:",inline"`
	metav1.ObjectMeta `json:"metadata,omitempty"`
	Status            RouteAgentStatus `json:"status"`
}

type RouteAgentStatus struct {
	Version       string       `json:"version"`
	StatusFailure string       `json:"statusFailure"`
	RemoteEndpoints   []RemoteEndpoint `json:"remoteEndpoints"`
}

type RemoteEndpoint struct {
	Status        ConnectionStatus `json:"status"`
	StatusMessage string           `json:"statusMessage"`
	Spec      EndpointSpec     `json:"endpoint"`
	// +optional
	LatencyRTT *LatencyRTTSpec `json:"latencyRTT,omitempty"`
}

Thanks @tpantelis for the input. Yes, I was exploring various thoughts and was thinking of reusing the existing gateway status. This idea looks better, I will work in this direction.

[aswinsuryan]

The RA health checker needs unit tests 😄

I will add the UTs. :)

[submariner-bot]

🤖 Closed branches: [z_pr3077/aswinsuryan/route-agent-health-checker]