Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Gateway status updates #502

Merged
merged 9 commits into from
Apr 22, 2020
Merged

Implement Gateway status updates #502

merged 9 commits into from
Apr 22, 2020

Commits on Apr 22, 2020

  1. Synchronize Gateway status into the local k8s API 

    Related-Issue: submariner-io#308
    @mangelajo
    mangelajo committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    8d55d38 View commit details
    Browse the repository at this point in the history

  2. Remove the Host field from Gateway and add localEndpoint 

    The Host field was redudant with the Gateway name, also the localEndpoint
information was missing when looking at the Gateway via describe for more
context.

Modified as discussed over slack channel.
    @mangelajo
    mangelajo committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    85091dc View commit details
    Browse the repository at this point in the history

  3. Stale gateway handling 

    The active gateway handles the role of cleaning up stale gateway entries,
if a gateway has not reported for x3 the reporting interval the entry will
be deleted. We handle this via an annotation since k8s API does not include
modification timestamp in the object metadata.
    @mangelajo
    mangelajo committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    9d64ccc View commit details
    Browse the repository at this point in the history

  4. Normalize API values to lowcase 

    In this way, when we use some of those also as labels it's less weird
since the unwritten norm in k8s is to use lowcase values in the labels
instead of upcase.
    @mangelajo
    mangelajo committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    808189a View commit details
    Browse the repository at this point in the history

  5. Apply sridhar's review comments

    @mangelajo
    mangelajo committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    e3006e6 View commit details
    Browse the repository at this point in the history

  6. Gateway reporting API E2E testing

    @mangelajo
    mangelajo committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    edbc7d1 View commit details
    Browse the repository at this point in the history

  7. Separate into a separate syncer object

    @mangelajo
    mangelajo committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    dfe2d07 View commit details
    Browse the repository at this point in the history

  8. Handle comments by tpantelis

    @mangelajo
    mangelajo committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    25b5afd View commit details
    Browse the repository at this point in the history

  9. Handle tpantelis comments including the move of e2e logic to redundan… 

    …cy tests
    @mangelajo
    mangelajo committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    4288cf7 View commit details
    Browse the repository at this point in the history