New Error and cleanup function for CreateRunnableCmd failures #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Cmd failures Based on the conv in suborbital#119, we want to delete the output dir of `sudo create runnable` for any failure that occurs in `CreateRunnableCmd`. `CreateRunnableError`s `Error` will also act as a cleanup function for these failures. atm, it's only deleting the output dir. Ideally, cobra.Command would have a error callback feature... maybe we'll get one for Xmas. spf13/cobra#914
denopink
changed the title
danielledeleo
suggested changes
Nov 24, 2021
Co-authored-by: Jagger De Leo <jcdl@fastmail.com>
…errors for CreateRunnableCmd() failures Based on pr feedback suborbital#135 (comment) Co-Authored-By: Jagger De Leo <jagger@suborbital.dev>
danielledeleo
approved these changes
Nov 24, 2021
|
Closes #119 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #119
Based on the conv in #119, we want to delete the output dir of
sudo create runnablefor any failure that occurs inCreateRunnableCmd.Replication steps:
subo create runnable foobar --lang somethingnotsupportedCreateRunnableErrorsErrorwill also act as a cleanup function for these failures. atm, it's only deleting the output dir.Ideally, cobra.Command would have a error callback feature when RunE fails... maybe we'll get one for Xmas. spf13/cobra#914
Off topic, I wish cobra.Command had a error callback for each of their run
Efunctions (RunE,PreRunE,PostRunE,PersistentPreRunE,PersistentPostRunE). They have a callback for when flag parsing fails. I'll create an issue ticket requesting this if it doesn't already exist.