test: update tests to depends on platform go middleware #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change exchange the dependency on: "github.com/redhatinsights/module-update-router/identity" by: "github.com/redhatinsights/platform-go-middlewares/identity" to avoid transition dependency on the dead repository: https://github.com/mitchellh/osext Signed-off-by: Alejandro Visiedo <avisiedo@redhat.com>
Signed-off-by: Alejandro Visiedo <avisiedo@redhat.com>
This change update the tests to fit the changes (now depending on Identity from platform-go-middlewares). Additionally, it is used pointy methods to generate pointer to values. Signed-off-by: Alejandro Visiedo <avisiedo@redhat.com>
Remove the utils.go file as with the current state they are not needed; and this will fix the linter violation in the pipeline. Signed-off-by: Alejandro Visiedo <avisiedo@redhat.com>
|
@subpop Continuing here from comments at #2 For clarification, as I see three different reads, which option is preferred? (1) Do not squash any commit and merge the PR as it is. In any case, close #2 as that changes are included here. What is the approached you prefer? |
|
thanks for your time! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change update the tests to fit the changes at #2
It uses the pointy library, which after the refactor of the tests the helpers at util.go are not required and removed in a second commit.
Depends on: #2