-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for disabling ipv6 #138
Conversation
I think this doesn't need an extra flag and could just be if ipv6 gateway is not present don't enable ipv6, likewise ipv4, if both are missing then log an error and exit ? |
d5ae96a
to
12e13f4
Compare
@gavinelder @jack1902 changed. Please review. |
12e13f4
to
d0e555e
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
While you may be right, it does not currently behave the way you describe. And if you disable ipv6 entirely in Ubuntu Focal, subspace won't even start properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks legit!
@all-contributors please add @dovreshef for code |
I've put up a pull request to add @dovreshef! 🎉 |
to:
cc: @subspacecommunity/subspace-maintainers
related to:
resolves:
Background
Add a new environment variable called
SUBSPACE_DISABLE_IPV6
, which is by default 0.When set to anything but 0, will disable IPV6 support for the tunnel completely.
Reason for the change
Some users have asked for a way to disable IPV6 completely (#117).
I've also found that with IPV6 enabled, the tunnel DNS forwarding did not work for me on some configuration. Since I do not need IPV6, it was easier to just disable it.
Testing
Steps for how this change was tested and verified
I've deployed this and verified that it is working.
I do not know how to test this further. But the changes are not so big.