Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for disabling ipv6 #138

Merged
merged 1 commit into from
May 16, 2021

Conversation

dovreshef
Copy link

@dovreshef dovreshef commented Sep 17, 2020

to:
cc: @subspacecommunity/subspace-maintainers
related to:
resolves:

Background

Add a new environment variable called SUBSPACE_DISABLE_IPV6, which is by default 0.
When set to anything but 0, will disable IPV6 support for the tunnel completely.

Reason for the change
Some users have asked for a way to disable IPV6 completely (#117).
I've also found that with IPV6 enabled, the tunnel DNS forwarding did not work for me on some configuration. Since I do not need IPV6, it was easier to just disable it.

Testing

Steps for how this change was tested and verified
I've deployed this and verified that it is working.
I do not know how to test this further. But the changes are not so big.

@gavinelder
Copy link

I think this doesn't need an extra flag and could just be if ipv6 gateway is not present don't enable ipv6, likewise ipv4, if both are missing then log an error and exit ?

@dovreshef
Copy link
Author

@gavinelder @jack1902 changed. Please review.

@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@skaag
Copy link

skaag commented Jan 13, 2021

I think this doesn't need an extra flag and could just be if ipv6 gateway is not present don't enable ipv6, likewise ipv4, if both are missing then log an error and exit ?

While you may be right, it does not currently behave the way you describe. And if you disable ipv6 entirely in Ubuntu Focal, subspace won't even start properly.

Copy link

@skaag skaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit!

@agonbar agonbar merged commit d8b7d79 into subspacecommunity:master May 16, 2021
@agonbar
Copy link
Collaborator

agonbar commented May 20, 2021

@all-contributors please add @dovreshef for code

@allcontributors
Copy link

@agonbar

I've put up a pull request to add @dovreshef! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants