added option to disable dns in wireguard conf

[gchamon]

to:
cc: @subspacecommunity/subspace-maintainers
related to:
resolves:

Background

To avoid wrong regional DNS resolution, which would cause international users to try to connect to the wrong servers when using the DNS provided by subspace, an option should exist to disable the DNS entry in wireguard conf.

Changes

• added env var SUBSPACE_DISABLE_DNS which acts as a toogle and, when set, causes new config files to be created with the DNS entry ommited.
• disabling dnsmasq if the flag is set
• updating readme

Testing

Create a new subspace instance with SUBSPACE_DISABLE_DNS=1, create a new config file, check if DNS = in wg0.conf is ommited:

[Interface]
PrivateKey = {REDACTED}
Address = 10.99.97.2/24,fd00::10:97:2/64

[Peer]
PublicKey = XIvA8kM+O9M+FGgR1SvkCv2DDrxWah+wp10tRfYAVzU=

Endpoint = {REDACTED}:51820
AllowedIPs = 0.0.0.0/0, ::/0

[agonbar]

Hi! I tested this, but I think it needs a bit more work.

Right now, the dnsmasq server is still getting launched without taking into consideration the env variable. To avoid unnecesary confusion, the DNS server should only be started if needed.

Also, adding a new var to the config, should be on the Docker-Compose Example section of the readme, or maybe we can refactor the way we explain all this vars to the users.

Well, aslo, this needs a rebase from master to solve some conflicts, I saw what the difference was and it should be easy to integrate while adding what I said.

[gchamon]

@agonbar I think refactoring the readme to make the env vars easier to understand for the users is worth its own separate issue. I will, however update my PR with your suggestions

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[agonbar]

Nice! I just tried this, it works! Sorry for the delay. Respecting the other PR, a rebase can be made and any extra feature can be introduced there.

[agonbar]

@all-contributors please add @gchamon for code

[allcontributors]

@agonbar

I've put up a pull request to add @gchamon! 🎉