Fix git ignores entire cmd/subspace folder #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only need to ignore subspace bin produced by build process
|
Kudos, SonarCloud Quality Gate passed!
|
|
@jack1902 please help me review this. TIA! |
gchamon
approved these changes
May 11, 2021
agonbar
approved these changes
May 16, 2021
|
@all-contributors please add @nhamlh for code |
|
I've put up a pull request to add @nhamlh! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only need to ignore subspace bin produced by build process
to:
cc: @subspacecommunity/subspace-maintainers
related to:
resolves:
Background
Reason for the change
Changes
Testing
Steps for how this change was tested and verified