Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented environment variables #191

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

syphernl
Copy link

@syphernl syphernl commented Jun 7, 2021

to: @subspacecommunity/subspace-maintainers
cc: @subspacecommunity/subspace-maintainers
related to:
resolves:

Background

I came across the SUBSPACE_ALLOWED_IPS environment variable which was not documented, decided to document the environment variables so it is clear which one's can be used.

Changes

  • Documented the available / used environment variables in the readme.

@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gchamon
Copy link

gchamon commented Jun 8, 2021

Neat! Can we merge this @agonbar ?

Copy link
Collaborator

@agonbar agonbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@agonbar agonbar merged commit 32fd13b into subspacecommunity:master Jun 8, 2021
@syphernl syphernl deleted the feat/docs_env_vars branch June 9, 2021 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants