dnsmasq fix

[maduggan]

to: @subspacecommunity/subspace-maintainers
related to:
resolves: #199

Background

Clients were reporting DNS timeouts every few hours with subspace, with the only resolution being to either restart the container or turn off DNS. Upon investigating, it seems subspace is using the wrong flag for dnsmasq, passing a debug flag instead of the approved production flag. This switches that. See: https://thekelleys.org.uk/dnsmasq/docs/dnsmasq-man.html

Debug mode: don't fork to the background, don't write a pid file, don't change user id, generate a complete cache dump on receipt on SIGUSR1, log to stderr as well as syslog, don't fork new processes to handle TCP queries. Note that this option is for use in debugging only, to stop dnsmasq daemonising in production, use --keep-in-foreground.

Changes

• changes the flag from --no-daemon to -keep-in-foreground

Testing

root      4030  0.0  0.0    784     4 ?        Ss   11:49   0:00          \_ runsv dnsmasq
nfsnobo+  4036  0.0  0.0   2188  1692 ?        S    11:49   0:00          |   \_ /usr/sbin/dnsmasq --keep-in-foreground
$ docker-compose ps
  Name                Command               State   Ports
---------------------------------------------------------
subspace   /usr/local/bin/entrypoint. ...   Up
CONTAINER ID   IMAGE                                     COMMAND                  CREATED       STATUS          PORTS     NAMES
ad67ccc1ba2c   subspacecommunity/subspace:amd64-v1.5.0   "/usr/local/bin/entr…"   4 weeks ago   Up 3 weeks             subspace

Currently running a prolonged test with a few dozen users and so far everything looks good

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[gchamon]

Please, keep us updated with the results from your prolonged test!

Nice catch, thanks!

[gchamon]

I am pre-emptively approving this, because indeed the docs show --no-daemon being a DEBUG flag not suited for production. Still interested in seeing results from prolonged tests. @agonbar

[maduggan]

@gchamon testing with about 30 daily users, all using subspace for dns. Went from requiring an hourly restart to not having restarted for two weeks. Glad to post any diagnostic logs since we’re also capturing those.

[jfrede]

Works fine seems to solve the Problem

[gchamon]

@jfrede good to know! thanks for the feedback

[agonbar]

Sorry for the long silence, I was a bit busy with life.

This looks awesome! I've suffered from this bug too. And the documentation also seems to back the change. I'm merging it. Many thanks @maduggan

[agonbar]

@all-contributors please add @maduggan for code

[allcontributors]

@agonbar

I've put up a pull request to add @maduggan! 🎉

[annuh]

We need to restart our Wireguard server from time to time to fix DNS issues. So thanks for this PR! Hopefully this will fix our issue as wel 🤞

Would it be possible to create a new release that includes this PR? v1.5.0...master