Allow Number type in updateIn function

[avevlad]

Test case:

u.updateIn(0, 123, [1, 2, 3]);

Before output:

     TypeError: path.split is not a function
      at splitPath (lib/util/splitPath.js:7:17)

After:

[123, 2, 3]

[aaronjensen]

I don't think we need all of the things that lodash/toString does, can you just use (path + '') instead please?

[avevlad]

ok

[aaronjensen]

Awesome, thanks for the tests, though could you follow the existing style of tests, specifically:

• blank lines between tests
• complete sentences (when "it" is prepended) for the test names, e.g. it('treats a number as a single step path')

[avevlad]

you're right, ok

[avevlad]

@aaronjensen

describe('splitPath', () => {
  it('treats only number', () => {
    const path = 1;
    const result = splitPath(path);
    expect(result).to.deep.equal(['1']);
  });

  it('treats only number', () => {
    const path = 0;
    const result = splitPath(path);
    expect(result).to.deep.equal(['0']);
  });

  it('treats simple array', () => {
    const path = ['foo', 'bar', 'x'];
    const result = splitPath(path);
    expect(result).to.equal(path);
  });

  it('treats a number as a single step path', () => {
    const path = 'bar.0.y';
    const result = splitPath(path);
    expect(result).to.deep.equal(['bar', '0', 'y']);
  });
});

so, it's ok? 😃

[aaronjensen]

sorry, my example was meant to be for the first.

You can certainly simplify, but I would use the word "handles" instead of "treats", since "treats" requires something like "as a ..." at the end of the sentence.

So, "it handles numbers", "it handles arrays", "it handles strings separated by dots"

You can probably get rid of either the 0 or the 1 test, you don't really need them both and they'd have the same name.

[avevlad]

@aaronjensen

import { expect } from 'chai';
import splitPath from '../../lib/util/splitPath';

describe('splitPath', () => {
  it('treats a number as a single step path', () => {
    const path = 1;
    const result = splitPath(path);
    expect(result).to.deep.equal(['1']);
  });

  it('handles arrays', () => {
    const path = ['foo', 'bar', 'x'];
    const result = splitPath(path);
    expect(result).to.equal(path);
  });

  it('handles strings separated by dots', () => {
    const path = 'bar.0.y';
    const result = splitPath(path);
    expect(result).to.deep.equal(['bar', '0', 'y']);
  });
});

[aaronjensen]

looks great!

[avevlad]

@aaronjensen done :)

[aaronjensen]

Looks great, thank you for the contribution @avevlad

[avevlad]

@aaronjensen thanks you! 👍

[aaronjensen]

@avevlad released 1.0.0, thanks again