Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update bft's substrait version #100

Merged
merged 1 commit into from
Dec 10, 2024
Merged

update bft's substrait version #100

merged 1 commit into from
Dec 10, 2024

Conversation

srikrishnak
Copy link
Contributor

This is needed to switch to using test cases from substrait

@srikrishnak
update bft's substrait version
f25d749 
This is needed to switch to using test cases from substrait
@srikrishnak
Copy link
Contributor Author

This PR only affects build site test(passes). Other tests are not impacted by this PR.

EpsilonPrime
EpsilonPrime approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@EpsilonPrime EpsilonPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to drop this check that typically occurred with different argument types of the same function. (For instance, divide had floating point related options on fp64 but not on int64.)

@EpsilonPrime EpsilonPrime merged commit 621bcb2 into substrait-io:main Dec 10, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EpsilonPrime EpsilonPrime EpsilonPrime approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srikrishnak @EpsilonPrime