Run tests from substrait #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikrishnak
force-pushed
the
run-tests-from-substrait
branch
21 times, most recently
from
6e133d8 to
e3cb637
Compare
srikrishnak
force-pushed
the
run-tests-from-substrait
branch
from
e3cb637 to
2f0f58f
Compare
srikrishnak
force-pushed
the
run-tests-from-substrait
branch
4 times, most recently
from
692f21a to
b9f38da
Compare
1. Fix dialects to only contain the supported functions 2. Don't raise exception if a test case's arguments don't match with the supported kernel. It is not a failure case. Examples can include regexp string functions. 3. Update Dockerfiles to install the required packages
srikrishnak
force-pushed
the
run-tests-from-substrait
branch
from
b9f38da to
841f636
Compare
EpsilonPrime
approved these changes
Dec 12, 2024
| @@ -161,8 +159,6 @@ def __supports_case_kernel( | |||
| if matched: | |||
| return None | |||
|
|
|||
| if not arg_len_matched: | |||
There was a problem hiding this comment.
Long term we are going to want to be strict about the argument counts. Perhaps add an issue to track bringing these back?
There was a problem hiding this comment.
filed issue #103 . Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the supported kernel. It is not a failure case. Examples can include
regexp string functions.