Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Location Search #100

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Adding Location Search #100

wants to merge 7 commits into from

Conversation

jhd3197
Copy link

@jhd3197 jhd3197 commented Feb 11, 2021

No description provided.

Adding blur and adjusting some default parameters
When location is set in post its doing a location search for the lat and picking the first one sometimes works sometimes it doesn't so i added a patch for that and also the TopSearchesPublicMixin.top_search was broken because it was doing a public request when it should be a private request
adding location_search_pk and location_search_name
Copy link
Contributor

@adw0rd adw0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Why need storyUpload in photo_upload? Use photo_upload_to_story for uploading photo to story
  2. extract_locationV2 - broken naming in the project (use extract_location_v2)
  3. Error using private requests in a public module, this makes no sense (You use private_request in public.py module)
  4. The rest of the functions for working with GEO (location) will still need to be checked, I did not see any tests on them

@@ -366,12 +366,13 @@ Upload medias to your feed. Common arguments:

* `path` - Path to source file
* `caption` - Text for you post
* `storyUpload` - If True will create a story from image (default: False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why need storyUpload in photo_upload? Use photo_upload_to_story for uploading photo to story

@@ -234,7 +234,7 @@ def top_search(self, query):
"rank_token": 0.7763938004511706,
"include_reel": "true",
}
response = self.public_request(url, params=params, return_json=True)
response = self.private_request(url, params=params)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error using private requests in a public module, this makes no sense (You use private_request in public.py module)



def extract_locationV2(data):
"""Extract location info"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extract_locationV2 - broken naming in the project (use extract_location_v2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants