fix: memory not added to checkpoint in unconstrained mode #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctian1
force-pushed
the
chris/fix-memory-global-collision
branch
from
5bd4889
to
a9f8dc3
Compare
|
SP1 Performance Test Results PR: fix: memory not added to checkpoint in unconstrained mode
|
ctian1
added a commit
that referenced
this pull request
Aug 29, 2024
yuwen01
pushed a commit
that referenced
this pull request
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were running into a rare runtime issue where the runtime diverges from intended behavior when running from a checkpoint. Multiple checkpoints were halting, resulting in duplicate memory init/finalize records. Root cause is because mode is set to Simple in unconstrained mode, but checkpoint memory is only saved in Checkpoint mode.
Fix is to also save checkpoint memory if in unconstrained mode.