Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: segfault on m3 #1484

Merged
merged 3 commits into from
Sep 5, 2024
Merged

fix: segfault on m3 #1484

merged 3 commits into from
Sep 5, 2024

Conversation

yuwen01
Copy link
Contributor

@yuwen01 yuwen01 commented Sep 5, 2024

I used an old version of sysinfo, causing segfaults only on macs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024 •
edited
Loading

SP1 Performance Test Results

Branch: yuwen/fix-segfault
Commit: 7f38873a
Author: yuwen01

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.18 5.57 0.15 1m16s ✅
ssz-withdrawals 2757356 14.04 59.20 22.35 2m50s ✅
tendermint 12593597 6.03 151.79 94.60 3m38s ✅

tqn
tqn approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@tqn tqn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note that there are actually later versions of sysinfo out, and sdk doesn't even seem to actually use the crate. (I'm currently looking at removing unused dependencies.)

@yuwen01 yuwen01 merged commit 770bf0d into dev Sep 5, 2024
10 checks passed
@yuwen01 yuwen01 deleted the yuwen/fix-segfault branch September 5, 2024 18:53
kevjue
kevjue reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@kevjue kevjue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevjue kevjue kevjue left review comments

@tqn tqn tqn approved these changes

@tamirhemo tamirhemo Awaiting requested review from tamirhemo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuwen01 @tqn @kevjue