Test patch version 3.2.0 of curve25519-dalek #1662
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SP1 Performance Test Results Branch: umadayal/test-curve25519
|
examples/Cargo.toml
Outdated
| @@ -59,7 +59,8 @@ sp1-lib = { path = "../crates/zkvm/lib", default-features = false } | |||
| sp1-zkvm = { path = "../crates/zkvm/entrypoint", default-features = false } | |||
|
|
|||
| [patch.crates-io] | |||
| curve25519-dalek = { git = "https://github.com/sp1-patches/curve25519-dalek", branch = "patch-curve25519-v4.1.3" } | |||
| ed25519-dalek = { git = "https://github.com/sp1-patches/ed25519-dalek.git", branch = "patch-ed25519-v1.0.1"} | |||
| curve25519-dalek = { git = "https://github.com/sp1-patches/curve25519-dalek", branch = "patch-curve25519-v3.2.0"} | |||
There was a problem hiding this comment.
Shouldn't you keep the original curve25519-dalek patch here? Or did that break your logic because it was patching the version of curve25519-dalek inside of ed25519-dalek?
Preferably, I'd like to have a patch for ed25519-dalek with curve25519-dalek version 3.x and then a patch for curve25519-dalek with version 4.x.
There was a problem hiding this comment.
It seems like I need to patch both ed25519 and curve25519-dalek version 3.x or I get errors
Comment on lines
82
to
94
| /// Emits ED_DECOMPRESS syscall. | ||
| // fn test_curve25519_dalek_v3() { | ||
| // let input = [1u8; 32]; | ||
| // let y = CompressedEdwardsY_dalek_v3(input); | ||
|
|
||
| // println!("cycle-tracker-start: curve25519-dalek-v3 decompress"); | ||
| // let decompressed_key = y.decompress(); | ||
| // println!("cycle-tracker-end: curve25519-dalek-v3 decompress"); | ||
|
|
||
| // let compressed_key = decompressed_key.unwrap().compress(); | ||
| // assert_eq!(compressed_key, y); | ||
| // } | ||
|
|
There was a problem hiding this comment.
Why is this commented out?
nhtyy
added
the
maybe-stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.