Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: get rid of all assignment ops in airs #1699

Merged
merged 8 commits into from
Oct 29, 2024
Merged

feat: get rid of all assignment ops in airs #1699

merged 8 commits into from
Oct 29, 2024

Conversation

jtguibas
Copy link
Contributor

No description provided.

@jtguibas jtguibas marked this pull request as draft October 26, 2024 03:22
@jtguibas jtguibas marked this pull request as ready for review October 28, 2024 15:33
@adr1anh
Copy link

adr1anh commented Oct 28, 2024

Out of curiosity, what's the reasoning behind this change? Are arithmetic operators less efficient in some situations?

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

SP1 Performance Test Results

Branch: john/remove-assign-in-airs
Commit: 87ed39e6
Author: jtguibas

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.19 2.73 0.35 32s ✅
ssz-withdrawals 2757356 18.26 127.75 31.89 1m27s ✅
tendermint 12593597 6.88 268.73 93.46 2m17s ✅

@jtguibas
Copy link
Contributor Author

@adr1anh I noticed that the it helps both recursion / the gpu prover if the AIR definition assumes write-once memory.

erabinov
erabinov approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@erabinov erabinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jtguibas jtguibas merged commit cdbba27 into dev Oct 29, 2024
11 checks passed
@jtguibas jtguibas deleted the john/remove-assign-in-airs branch October 29, 2024 17:48
@jtguibas jtguibas restored the john/remove-assign-in-airs branch October 29, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erabinov erabinov erabinov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtguibas @adr1anh @erabinov