Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added --ignore-rust-version to cargo prove build #462

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

CeciliaZ030
Copy link
Contributor

Subcommands like build allow ignoring the minimum rust version of dependencies by the --ignore-rust-version flag. Given that Sp1 locks on certain rustc version while the dependencies of zkvm guest code might often require a higher version, we should allow users to optimistically compile guests without this check.

Inspired by: rust-lang/cargo#11718

cli/src/build.rs Outdated Show resolved Hide resolved
cli/src/build.rs Outdated Show resolved Hide resolved
cli/src/build.rs Outdated Show resolved Hide resolved
cli/src/build.rs Outdated
workspace_root_path.as_str(),
image.as_str(),
"prove",
"check",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be build I believe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! sry typo.

@jtguibas jtguibas merged commit 3d3ac67 into succinctlabs:main Apr 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants