Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arduino.mk: added PRE_UPLOAD_HOOK macro to specify script to run befo… #585

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

evrokas
Copy link

@evrokas evrokas commented Oct 11, 2018

I have added a PRE_UPLOAD_HOOK macro and a new phony target in Arduino.mk (pre-upload) to execute a shell script just before uploading the code to the chip.
Also modified arduino-mk-vars.md to the description of the PRE_UPLOAD_HOOK

added AVR_SIZE_OPTS when using $(NM) to dump symbols,
[taret upload]: added prerequestive pre-upload in order to execute the PRE_UPLOAD_HOOK script,
[added target pre-upload] to execute PRE_UPLOAD_HOOK script,
[.PHONY]: added target pre-upload,
arduino-mk-vars.md: added description for PRE_UPLOAD_HOOK

…re uploading code,

added AVR_SIZE_OPTS when using $(NM) to dump symbols,
[taret upload]: added prerequestive pre-upload in order to execute the PRE_UPLOAD_HOOK script,
[added target pre-upload] to execute PRE_UPLOAD_HOOK script,
[.PHONY]: added target pre-upload,
arduino-mk-vars.md: added description for PRE_UPLOAD_HOOK
@sej7278
Copy link
Collaborator

sej7278 commented Oct 12, 2018

AVR_SIZE_OPTS isn't defined/explained anywhere.

pre-upload hook makes sense like pre-build hook

@evrokas
Copy link
Author

evrokas commented Oct 12, 2018

I am very sorry, I didn't document the option.
Actually, I used it sometimes in order to change the base (from hexadecimal to decimal) of
the size of the symbols (such as avr-nm -t d [options...])

Do you find it useful in order to make the necessary changes?

regards,
Evangelos

@sej7278
Copy link
Collaborator

sej7278 commented Oct 13, 2018

ah i see what it is for now, yes with some documentation it would be useful thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants