Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renaming PRODUCT and MANUFACTURER for Caterina devices like leonardo #612

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

G33kLabs
Copy link

It works with that in the Makefile (all without quotes) :

USB_MANUFACTURER = MANUFACTURER_NAME
USB_PRODUCT = PRODUCT_NAME

@sej7278
Copy link
Collaborator

sej7278 commented Aug 25, 2019

this seems to break cores that actually use these settings e.g. the adafruit ones, where they use quotes:

feather32u4.build.usb_product="Feather 32u4"
feather32u4.build.usb_manufacturer="Adafruit"

the makefile without your patch works fine if you also use quotes, which you should do anyway as the strings may have spaces:

USB_PRODUCT = "product with spaces"

@G33kLabs
Copy link
Author

Ok, will check you that tomorrow with electronics near.

@sudar
Copy link
Owner

sudar commented Sep 3, 2020

@G33kLabs

Did you get a chance to check it with the real hardware?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants