Add PLATFORM_PATH #619
Open
Add PLATFORM_PATH #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add PLATFORM_PATH variable to the root hardware directory for a given architecture to avoid duplication between boards.txt, cores, platform libraries, etc.
Build is failing because pyserial 3.0.1 is already installed and can't be uninstalled. Instead, add --ignore-installed flag to pip command so that pyserial 2.7 will be installed without the need to uninstall 3.0.1.
|
Thanks for your contribution and sorry for the delay in getting back to you. What are your thoughts on this? |
|
not really sure what the use case for this would be if its not used with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PLATFORM_PATH variable to the root hardware directory for a given
architecture to avoid duplication between boards.txt, cores, platform
libraries, etc.
I needed to access this value and was hoping to inherit it, when I learned that it did not exist as a distinct variable in Arduino.mk. It seemed like it would be generally useful and a bit more DRY to define it independently. So I thought I would offer it in case you find it useful. No worries if you'd rather not.
I opted to avoid setting PLATFORM_PATH in the case where any of the ALTERNATE_CORE variables are set. I realize that there is some duplication between the concepts and it may be confusing. I figured sticking with the minimally invasive simple refactoring was safest.