Refactor Observer #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR does three things: 1. Removes the nested if loops and makes that part readable by adding more functions. 2. Adds some tests (this needs more work to add an exact tcp packet like unit test. Also introduces a stop mechanism to the observer for the tests primarily. 3. Make the hashmap ttl-like so abandoned SYN packets are not stored forever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does three things:
Removes the nested if loops and makes that part readable by adding more functions.
Adds some tests (this needs more work to add an exact tcp packet like unit test. Also introduces a stop mechanism to the observer for the tests primarily.
Make the hashmap ttl-like so abandoned SYN packets are not stored forever.