Merge throws error on successful merge

[Ryukote]

Hi,

I have this workflow:

name: Test Pipeline

on: [pull_request]

jobs:
  build-and-test:

    runs-on: ubuntu-latest

    steps:
    - uses: actions/checkout@v2
      with:
        repository: 'ryukote/carbooking-api' 
        fetch-depth: '0' 
    - name: Setup .NET Core
      uses: actions/setup-dotnet@v1
      with:
        dotnet-version: 3.1.101
    - name: Build with dotnet
      run: dotnet build ./ConsoleApp1/ConsoleApp1.sln --configuration Release
    - name: Test with dotnet
      run: dotnet test ./ConsoleApp1/ConsoleApp1.sln
      
  pull-request:
    needs: build-and-test
    runs-on: ubuntu-latest
    steps:
    - name: Merge Pull Request
      uses: sudo-bot/action-pull-request-merge@v1.0.3
      with:
        github-token: "${{ secrets.TOKEN }}"
        number: ${{ github.event.pull_request.number }}  
        merge-method: merge
        merge-title: "Merge #${{ github.event.pull_request.number }}"
        merge-message: "Merge #${{ github.event.pull_request.number }}"

Your action merges pull request, but for some reason it throws error "##[error]Label does not exist".
Cause of that it says workflow didn't pass, even tho pull request was merged.

Do you maybe have any idea what should I do?

Thank you.

[williamdes]

Hi @Ryukote!
Thank you for the issue, I will fix this behavior and update the current version

It is a bug and I also hate it ^^

Have a nice day

[williamdes]

https://github.com/sudo-bot/action-pull-request-merge#example-usages

But for now maybe you are missing filter-label: merge-it?

[Ryukote]

I have tried with it first. Same thing. Can you please tag me in the comment here when you update it?

[williamdes]

@Ryukote do you expect the workflow to merge if no label is given ?

[Ryukote]

Yes, cause in 95% I don't put a label on pull request.

[williamdes]

Okay, I will make it not required for you

[williamdes]

FTR:

• https://github.com/Ryukote/CarBooking-API/runs/469085493?check_suite_focus=true#step:2:12
• The same error for a different reason https://github.com/williamdes/mariadb-mysql-kbs/actions/runs/43461808

I will catch the case where another workflow did remove the label (concurrent workflows)

[williamdes]

Version is out https://github.com/sudo-bot/action-pull-request-merge/releases/tag/v1.1.0 🚀
Please have a try and let me know if it works as you expect

[williamdes]

Now it throws a warning but In your case you should not have it
https://github.com/sudo-bot/action-pull-request-merge/runs/470709819?check_suite_focus=true#step:2:12

[Ryukote]

Now it works like a charm. I didn't expect that you will fix it this fast. Thanks.

[williamdes]

Now it works like a charm. I didn't expect that you will fix it this fast. Thanks.

Happy that I could help you build great workflows ;)